LG-15484: Update design of Sign In/Create Account tabs#11872
Merged
Conversation
changelog: User-Facing Improvements, Sign In, Improve design clarity of "Sign In" / "Create an Account" tabs
kevinsmaster5
approved these changes
Feb 12, 2025
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good and tests out locally.
Seems to need a handful of specs to be relabeled and should be ready to go 👍
Contributor
Author
Thanks! Those tests are a good example of what we recently talked about with hard-coding labels 😄 |
Contributor
Author
|
I'm going to hold off on merging this until after tomorrow's deploy, so the changes from #11839 have enough time to collect sufficient data to compare the effectiveness of these changes. |
eileen-nava
pushed a commit
that referenced
this pull request
Feb 18, 2025
This reverts commit 4ab0dcb.
aduth
added a commit
that referenced
this pull request
Feb 18, 2025
aduth
added a commit
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15484
🛠 Summary of changes
Updates the visual appearance of the "Sign in" and "Create an Account" tabs on the sign-in page.
The intention of these changes is to improve the design clarity of the buttons being a tab control, since we have observed with the current (previous) designs that many users will click on the active button (e.g. "Sign in") while already on that page, with the expectation of it being a call-to-action button to continue signing in.
Changes also include some standardization of button appearance between the "Sign in" and "Create an account" pages:
📜 Testing Plan
Verify there are no regressions in toggling between "Sign in" and "Create an Account", including expected states of links (hover, focus, active).
Verify there are no regressions with submitting "Sign in" or "Create an Account" page forms.
👀 Screenshots