LG-15653 Pause Sending In Person Proofing Follow Up Survey Email#11867
Merged
gina-yamada merged 7 commits intomainfrom Feb 12, 2025
Merged
LG-15653 Pause Sending In Person Proofing Follow Up Survey Email#11867gina-yamada merged 7 commits intomainfrom
gina-yamada merged 7 commits intomainfrom
Conversation
…nding ipp follow up survey email
…53-PauseSendingIppFollowUpSurveryEmail
jennyverdeyen
approved these changes
Feb 11, 2025
Contributor
jennyverdeyen
left a comment
There was a problem hiding this comment.
Tested according to the steps you included. I set in_person_completion_survey_delivery_enabled to true, and I can see the survey gets sent when the enrollment passes, and follow_up_survey_sent is true on the enrollment.
I set in_person_completion_survey_delivery_enabled to false, and the survey doesn't appear when the enrollment passes and I connect to Sinatra. Upon inspecting the enrollment, it has status: "passed" and follow_up_survey_sent: false. 👍
Looks great!
shanechesnutt-ft
approved these changes
Feb 11, 2025
Contributor
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Did not run through the tests but everything looks good code wise. 👍🏻
…53-PauseSendingIppFollowUpSurveryEmail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15653 Implementation: Pause sending IPP follow up survey email
🛠 Summary of changes
in_person_completion_survey_delivery_enabledand set default value to false📜 Testing Plan
Test 1: Test previous behavior
in_person_completion_survey_delivery_enabledto trueTest 2: Test new behavior
in_person_completion_survey_delivery_enabledto false (This is the default now)👀 Screenshots
Here is an image of the In Person Completion Survey