Skip to content

LG-15653 Pause Sending In Person Proofing Follow Up Survey Email#11867

Merged
gina-yamada merged 7 commits intomainfrom
yamada/LG-15653-PauseSendingIppFollowUpSurveryEmail
Feb 12, 2025
Merged

LG-15653 Pause Sending In Person Proofing Follow Up Survey Email#11867
gina-yamada merged 7 commits intomainfrom
yamada/LG-15653-PauseSendingIppFollowUpSurveryEmail

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Feb 11, 2025

🎫 Ticket

LG-15653 Implementation: Pause sending IPP follow up survey email

🛠 Summary of changes

  • Add new config in_person_completion_survey_delivery_enabled and set default value to false
  • Add specs to test in person completion survey delivery and in person enrollment value

📜 Testing Plan

Test 1: Test previous behavior

  • Step 1 Set in_person_completion_survey_delivery_enabled to true
  • Step 2 Come in through Sinatra. Set up an account. Verify your identity through the in person flow. Mock passing results with USPS.
  • Step 3: Inspect your enrollment. Confirm follow_up_survey_sent is set to false.
  • Step 4: Connect app with Sinatra. (Sign back in via Sinatra)
  • Step 5: When you connect your app, the In Person Completion Survey email should be delivered.
  • Step 6: Inspect your enrollment. Confirm follow_up_survey_sent is set to true.

Test 2: Test new behavior

  • Step 1 Set in_person_completion_survey_delivery_enabled to false (This is the default now)
  • Step 2 Come in through Sinatra. Set up an account. Verify your identity through the in person flow. Mock passing results with USPS.
  • Step 3: Inspect your enrollment. Confirm follow_up_survey_sent is set to false.
  • Step 4: Connect app with Sinatra. (Sign back in via Sinatra)
  • Step 5: When you connect your app, the In Person Completion Survey email should not be delivered.
  • Step 6: Inspect your enrollment. Confirm follow_up_survey_sent is set to false.

👀 Screenshots

Here is an image of the In Person Completion Survey

Screenshot 2025-02-11 at 8 23 07 AM

Copy link
Contributor

@jennyverdeyen jennyverdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested according to the steps you included. I set in_person_completion_survey_delivery_enabled to true, and I can see the survey gets sent when the enrollment passes, and follow_up_survey_sent is true on the enrollment.

I set in_person_completion_survey_delivery_enabled to false, and the survey doesn't appear when the enrollment passes and I connect to Sinatra. Upon inspecting the enrollment, it has status: "passed" and follow_up_survey_sent: false. 👍

Looks great!

Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not run through the tests but everything looks good code wise. 👍🏻

@gina-yamada gina-yamada merged commit b9343dc into main Feb 12, 2025
2 checks passed
@gina-yamada gina-yamada deleted the yamada/LG-15653-PauseSendingIppFollowUpSurveryEmail branch February 12, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants