Conversation
Contributor
|
|
vrajmohan
approved these changes
Feb 10, 2025
Contributor
vrajmohan
left a comment
vrajmohan
left a comment
There was a problem hiding this comment.
Glad that we are still plugging away on this front.
Looks good to me.
mitchellhenke
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Add analytics to track integrations not passing
openidin the scope parameter🛠 Summary of changes
OIDC requests are supposed to have an
openidscope value in order to conform to the spec. We currently do not have a validation for that value, so many integrations not passing it through. This ticket is to add tracking to the weekly protocols report to get a list of integrations that are not conforming, so we can do targeted outreach to get them to update their requests.I have tested that the cloudwatch query is valid via:
aws-vault exec prod-power -- bundle exec rails runner lib/reporting/protocols_report.rb --date 2025-02-09