Invert default logging behavior for A/B test#11862
Merged
Conversation
changelog: Internal, Analytics, Invert default logging behavior for A/B test
zachmargolis
approved these changes
Feb 10, 2025
matthinz
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates the behavior of
AbTestto not include bucket assignments in logs ifshould_logis not defined.Previously, if a test did not define
should_log, the A/B test assignment for that test would be included in every application event. To avoid unnecessary noise in unrelated analytics events, this pull request proposes to change the default from an opt-out to an opt-in.Existing tests already assign
should_logand should be unimpacted by these changes.📜 Testing Plan
Verify build passes.
Optionally, delete the
should_logoption for one of the existing test configuration and verify withmake watch_eventsthat unrelated analytics events do not include the A/B test assignment.