LG-15693 undefined method profiles for nil#11861
Merged
Conversation
jmax-gsa
force-pushed
the
jmax/LG-15693-undefined-method-profiles-for-nil
branch
from
157a46a to
c655139
Compare
Spec fixes and a modification to rate limiting. changelog: Internal, Socure, Removed unnecessary before: filter bypasses
jmax-gsa
force-pushed
the
jmax/LG-15693-undefined-method-profiles-for-nil
branch
from
773edf5 to
ea238a9
Compare
amirbey
reviewed
Feb 10, 2025
Comment on lines
-38
to
-42
| flow_path = doc_session_idv['flow_path'] | ||
| return false if flow_path.blank? | ||
|
|
||
| return false if flow_path != 'hybrid' | ||
|
|
amirbey
reviewed
Feb 10, 2025
Comment on lines
+154
to
+156
| DocumentCaptureSession.find_by(user_id: @user.id).update( | ||
| last_doc_auth_result: 'Passed', | ||
| ) |
Contributor
There was a problem hiding this comment.
looking at the code this does not appear to happen in the Socure flow 🤔 ... which Is why this workaround is happening manually here
will address this in a follow up issue
amirbey
approved these changes
Feb 10, 2025
amirbey
reviewed
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket LG-15693
🛠 Summary of changes
We strongly suspect that the
before:filters should've caught this condition, but they were largely bypassed for the update event. It turns out that we don't need the bypasses if we change the rate-limiting logic slightly. Instead of making our before filter "smart", we simply pass in whether or not we should check for successful document capture.Removed the filter bypasses from
socure/document_capture_controller.rb📜 Testing Plan