Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.4.1
branch
2 times, most recently
from
832e52c to
60ac410
Compare
aduth
approved these changes
Feb 7, 2025
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.4.1
branch
from
60ac410 to
9670a4c
Compare
zachmargolis
reviewed
Feb 7, 2025
changelog: Internal, Maintenance, Update to Ruby 3.4.1
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.4.1
branch
from
cb978b8 to
9acb00e
Compare
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.4.1
branch
from
9151a39 to
f45a475
Compare
mitchellhenke
force-pushed
the
mitchellhenke/ruby-3.4.1
branch
from
f45a475 to
38bc641
Compare
mitchellhenke
commented
Feb 7, 2025
| .grep(/analytics_events\.rb/) | ||
| &.first | ||
| &.match(/:in `(?<method_name>[^']+)'/) | ||
| &.match(/:in '[\w\d]*#(?<method_name>[^']+)'/) |
Contributor
Author
There was a problem hiding this comment.
The caller method returns a different format in 3.4:
- "identity-idp/app/services/analytics_events.rb:4409:in `idv_phone_confirmation_otp_submitted'"
+ "identity-idp/app/services/analytics_events.rb:4409:in 'AnalyticsEvents#idv_phone_confirmation_otp_submitted'"
zachmargolis
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Ruby 3.4 was released a little over a month ago. This PR upgrades us to use the most recent version.