Omit errors from serialized form response if details present#11846
Merged
Omit errors from serialized form response if details present#11846
Conversation
changelog: Internal, Analytics, Omit errors from serialized form response if details present
No longer expecting errors keys in these
zachmargolis
approved these changes
Feb 6, 2025
| def to_h | ||
| hash = { success: success } | ||
| hash[:errors] = (!defined?(@error_details) && errors).presence if !serialize_error_details_only? | ||
| hash[:errors] = errors.presence if !defined?(@error_details) && !serialize_error_details_only? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
FormResponse#to_hto avoid includingerrorsin the serialized hash iferror_detailsis present.This is a continuation (cleanup) of #11810, which effectively omitted
errorsfrom analytics logging, but continued to assign the value asnil. The changes here avoid assigning the value altogether.Related: #11810 (comment)
📜 Testing Plan
Verify build passes.