Skip to content

LG-15672: Only redirect to select email screen if feature enabled#11845

Merged
aduth merged 1 commit intomainfrom
aduth-redirect-request-id-share-disabled
Feb 5, 2025
Merged

LG-15672: Only redirect to select email screen if feature enabled#11845
aduth merged 1 commit intomainfrom
aduth-redirect-request-id-share-disabled

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Feb 5, 2025

🎫 Ticket

LG-15672

🛠 Summary of changes

Fixes an issue where users may be redirected to the email selection experience even if the feature is disabled, resulting in a 404.

Related Slack thread: https://gsa-tts.slack.com/archives/C01710KMYUB/p1738779905418149

📜 Testing Plan

Test with and without feature_select_email_to_share_enabled enabled:

  1. Have sample application running in separate process
  2. Go to http://localhost:9292
  3. Click "Sign in"
  4. Sign in or create an account
  5. After returned to sample application, go to http://localhost:3000
  6. Add email address from account dashboard
  7. Confirm email address
  8. Observe that:
    • If feature is disabled, you're redirected to account dashboard with email selected
    • If feature is enabled, you're redirected to email selection screen

Previously, this would always redirect to email selection screen regardless if feature is enabled.

Follow-up work should explore whether email selection screen is the correct place to redirect in this workflow.

changelog: Upcoming Features, Partner Email Selection, Only redirect to select email screen if feature enabled
@aduth aduth requested a review from a team February 5, 2025 18:35
@aduth aduth changed the title Only redirect to select email screen if feature enabled LG-15672: Only redirect to select email screen if feature enabled Feb 5, 2025
Copy link
Copy Markdown
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good to me!

@aduth aduth merged commit 9de5343 into main Feb 5, 2025
@aduth aduth deleted the aduth-redirect-request-id-share-disabled branch February 5, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants