Lg 15476 hybrid rate limit final attempt bug fix#11837
Merged
AShukla-GSA merged 9 commits intomainfrom Feb 4, 2025
Merged
Conversation
amirbey
reviewed
Feb 3, 2025
solipet
reviewed
Feb 3, 2025
solipet
approved these changes
Feb 4, 2025
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Much cleaner! Just a couple of comments.
…attempt in hybrid flow
… change logic of status
AShukla-GSA
force-pushed
the
lg-15476-hybrid-rate-limit-final-attempt-bug-fix
branch
from
fc1362d to
b847a1b
Compare
AShukla-GSA
deleted the
lg-15476-hybrid-rate-limit-final-attempt-bug-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15476
🛠 Summary of changes
Modified hybrid flow rate limit logic to accept successful submission on final attempt. Had to move around some logic to keep logging intact. Added spec test to cover hybrid flow final submission.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.