changelog: Internal, In-person Proofing, Remove old single field addr…#11829
Merged
WilliamBirdsall merged 1 commit intomainfrom Feb 5, 2025
Merged
changelog: Internal, In-person Proofing, Remove old single field addr…#11829WilliamBirdsall merged 1 commit intomainfrom
WilliamBirdsall merged 1 commit intomainfrom
Conversation
WilliamBirdsall
force-pushed
the
will/LG-13804
branch
from
60b64ea to
defc9b4
Compare
aduth
reviewed
Jan 31, 2025
app/javascript/packages/address-search/components/address-input.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/address-search/components/address-input.tsx
Outdated
Show resolved
Hide resolved
...vascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx
Outdated
Show resolved
Hide resolved
WilliamBirdsall
force-pushed
the
will/LG-13804
branch
from
defc9b4 to
3326124
Compare
Contributor
|
Looks like the build caught a few left-over references. |
WilliamBirdsall
force-pushed
the
will/LG-13804
branch
from
3326124 to
bea1868
Compare
aduth
reviewed
Feb 5, 2025
WilliamBirdsall
force-pushed
the
will/LG-13804
branch
2 times, most recently
from
195f5f3 to
f6a14c2
Compare
…ess search from both the address-search package and step components that use it
WilliamBirdsall
force-pushed
the
will/LG-13804
branch
from
f6a14c2 to
951a912
Compare
eileen-nava
approved these changes
Feb 5, 2025
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
Good work, Will. Approved. 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13804
🛠 Summary of changes
Removal of old single form field address search component.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Note: This PR does not create a new build/dist of the address-search package, nor does it upload that to NPM.