Log errors for profile reactivate password submitted#11822
Merged
Conversation
Contributor
Author
|
This approach is also exactly what's documented in the aforementioned Forms documentation:
|
zachmargolis
approved these changes
Feb 10, 2025
changelog: Internal, Analytics, Log errors for profile reactivity password submitted
e074ab2 to
f5cf243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This pull request changes
VerifyPasswordFormto avoid assigningpersonal_keyonFormResponse#extraand instead assign as an instance variable accessible through a new attribute reader.Why?
extrais intended to be used for analytics logging and should exclude sensitive information (docs). Personal key is a very sensitive value, and while we've taken steps to ensure that it isn't logged, the previous implementation creates a lot of unnecessary risk that it could accidentally be logged in future changes.successvalues for this analytics event. By removing personal key fromextra, we can log the entire response usingFormResponse#to_h, including errors.📜 Testing Plan
Verify that the build passes.
Verify using
make watch_eventsthat submitting password after reactivating a profile disabled due to password reset logs thereactivate_account_verify_password_submittedevent (a) withoutpersonal_keyand (b) witherror_detailsif the submission is unsuccessful.