Conversation
We have received clarification on the following from our vendor: 1. The `Fields_Sex` attribute is no longer available in the `ID_AUTH_FIELDS` group 2. The `Sex` attribute available in the `AUTHENTICATION_RESULT` group can be used to reliably determine the sex displayed on the document 3. The `Sex` attribute in the `AUTHENTICATION_RESULT` group takes on the values of `Male` or `Female`. This commit updates the `DocPiiReader` and the TrueID response fixtures to reflect this. [skip changelog]
jmhooper
commented
Jan 29, 2025
| state: 'MD', | ||
| dob: '1986-07-01', | ||
| sex: nil, | ||
| sex: 'male', |
Contributor
Author
There was a problem hiding this comment.
This changed because this test is using the true_id_response_success_with_liveness.json fixture. This fixture was recorded recently so it did not include a Fields_Sex attribute. It does, however, contain a sex attribute in the AUTHENTICATION_RESULT group. The changes in this PR result in male being read from the response for the sex value.
matthinz
approved these changes
Jan 29, 2025
jmhooper
deleted the
jmhooper-read-sex-attribute-from-authentication-result
branch
n1zyy
pushed a commit
that referenced
this pull request
Jan 31, 2025
…#11819) We have received clarification on the following from our vendor: 1. The `Fields_Sex` attribute is no longer available in the `ID_AUTH_FIELDS` group 2. The `Sex` attribute available in the `AUTHENTICATION_RESULT` group can be used to reliably determine the sex displayed on the document 3. The `Sex` attribute in the `AUTHENTICATION_RESULT` group takes on the values of `Male` or `Female`. This commit updates the `DocPiiReader` and the TrueID response fixtures to reflect this. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have received clarification on the following from our vendor:
Fields_Sexattribute is no longer available in theID_AUTH_FIELDSgroupSexattribute available in theAUTHENTICATION_RESULTgroup can be used to reliably determine the sex displayed on the documentSexattribute in theAUTHENTICATION_RESULTgroup takes on the values ofMaleorFemale.This commit updates the
DocPiiReaderand the TrueID response fixtures to reflect this.