Skip to content

LG-15309 simple log pii validation to analytics#11813

Merged
jmax-gsa merged 11 commits intomainfrom
jmax/LG-15309-simple-log-pii-validation-to-analytics
Jan 29, 2025
Merged

LG-15309 simple log pii validation to analytics#11813
jmax-gsa merged 11 commits intomainfrom
jmax/LG-15309-simple-log-pii-validation-to-analytics

Conversation

@jmax-gsa
Copy link
Copy Markdown
Contributor

@jmax-gsa jmax-gsa commented Jan 28, 2025

🎫 Ticket

LG-15309

🛠 Summary of changes

Added logging of PII validation to the Socure document results job

📜 Testing Plan

  • Run the Socure normal flow feature spec. (spec/features/idv/doc_auth/socure_document_capture_spec.rb:391) and verify that an IdV: doc auth imag upload vendor pii validation event was logged.
  • Run the Socure hybrid feature specs. (spec/features/idv/hybrid_mobiile/hybrid_socure_mobile_spec.rb:46 and verify that an IdV: doc auth imag upload vendor pii validation event was logged.

@jmax-gsa jmax-gsa marked this pull request as ready for review January 28, 2025 18:29
@jmax-gsa jmax-gsa requested a review from amirbey January 28, 2025 18:29
jmax-gsa and others added 2 commits January 28, 2025 14:26
Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
@amirbey amirbey self-requested a review January 28, 2025 19:56
Copy link
Copy Markdown
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per chat, feature specs will add checks for logging analytics:

  • idv_socure_verification_data_requested
  • idv_doc_auth_submitted_pii_validation

LGTM ... thanks Jmax 🙏🏿

@jmax-gsa jmax-gsa merged commit b55429f into main Jan 29, 2025
@jmax-gsa jmax-gsa deleted the jmax/LG-15309-simple-log-pii-validation-to-analytics branch January 29, 2025 00:10
n1zyy pushed a commit that referenced this pull request Jan 31, 2025
Log Pii validation event to analytics in the Socure flow

changelog: Upcoming Features, Socure, Log Pii validation

---------

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants