Skip to content

Upgrade to Rails 8#11793

Merged
mitchellhenke merged 3 commits intomainfrom
mitchellhenke/rails-8
Jan 23, 2025
Merged

Upgrade to Rails 8#11793
mitchellhenke merged 3 commits intomainfrom
mitchellhenke/rails-8

Conversation

@mitchellhenke
Copy link
Copy Markdown
Contributor

🛠 Summary of changes

I don't see any potential breaking changes and deprecations that could affect us in the 8.0 release notes, so may as well go for it.

Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !!

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/rails-8 branch 2 times, most recently from 030de13 to 357421a Compare January 23, 2025 18:21
Mitchell Henke added 2 commits January 23, 2025 12:27
changelog: Internal, Maintenance, Upgrade to Rails 8
Copy link
Copy Markdown
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the target Rails version in the Rubocop configuration as well?

TargetRailsVersion: 7.2

end

config.load_defaults '7.2'
config.load_defaults '8.0'
Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few changes here:

# Specifies whether `to_time` methods preserve the UTC offset of their receivers or preserves the timezone.
# If set to `:zone`, `to_time` methods will use the timezone of their receivers.
# If set to `:offset`, `to_time` methods will use the UTC offset.
# If `false`, `to_time` methods will convert to the local system UTC offset instead.
Rails.application.config.active_support.to_time_preserves_timezone = :zone

# When both `If-Modified-Since` and `If-None-Match` are provided by the client
# only consider `If-None-Match` as specified by RFC 7232 Section 6.
# If set to `false` both conditions need to be satisfied.
Rails.application.config.action_dispatch.strict_freshness = true

# Set `Regexp.timeout` to `1`s by default to improve security over Regexp Denial-of-Service attacks.
Regexp.timeout = 1

I don't think any of them affect us though.

@mitchellhenke mitchellhenke merged commit 19b610a into main Jan 23, 2025
@mitchellhenke mitchellhenke deleted the mitchellhenke/rails-8 branch January 23, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants