Merged
Conversation
030de13 to
357421a
Compare
added 2 commits
January 23, 2025 12:27
changelog: Internal, Maintenance, Upgrade to Rails 8
357421a to
03a3a7c
Compare
aduth
reviewed
Jan 23, 2025
Contributor
There was a problem hiding this comment.
Should we update the target Rails version in the Rubocop configuration as well?
Line 33 in 03a3a7c
mitchellhenke
commented
Jan 23, 2025
| end | ||
|
|
||
| config.load_defaults '7.2' | ||
| config.load_defaults '8.0' |
Contributor
Author
There was a problem hiding this comment.
There are a few changes here:
# Specifies whether `to_time` methods preserve the UTC offset of their receivers or preserves the timezone.
# If set to `:zone`, `to_time` methods will use the timezone of their receivers.
# If set to `:offset`, `to_time` methods will use the UTC offset.
# If `false`, `to_time` methods will convert to the local system UTC offset instead.
Rails.application.config.active_support.to_time_preserves_timezone = :zone
# When both `If-Modified-Since` and `If-None-Match` are provided by the client
# only consider `If-None-Match` as specified by RFC 7232 Section 6.
# If set to `false` both conditions need to be satisfied.
Rails.application.config.action_dispatch.strict_freshness = true
# Set `Regexp.timeout` to `1`s by default to improve security over Regexp Denial-of-Service attacks.
Regexp.timeout = 1I don't think any of them affect us though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
I don't see any potential breaking changes and deprecations that could affect us in the 8.0 release notes, so may as well go for it.