Avoid printing preload_links_header attribute for scripts#11790
Merged
Conversation
changelog: Internal, JavaScript Helper, Avoid printing preload_links_header attribute for scripts
mitchellhenke
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where scripts rendered using
preload_links_header: falseoption unexpectedly output apreload_links_header="false"attribute on the rendered script tag.This regressed in #11504, where we switched from using
javascript_include_tagtotag.script. Thepreload_links_headerbehavior was intended to mimic that ofjavascript_include_tag, but did not recreate the behavior of deleting the option from attributes before rendering the script tag (source).📜 Testing Plan
track-errors.jsscript tag toward the bottom of page<body>content does not include apreload_links_headerattribute