LG-15394 Add tooling for an SP proofing events by UUID report#11787
Merged
LG-15394 Add tooling for an SP proofing events by UUID report#11787
Conversation
We have an agency partner who requested a specialized report the involves a table with columns representing proofing events and rows representing users for the partner where the values in each cell correspond to whether that user encountered that event in the given time period. We have been manually servicing this request for a little while. This commit adds tooling to generate this report automatically so it does not require manual processing. This commit does not add the report to the job schedule with the intention being to test it first before scheduling it to run automatically. [skip changelog]
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM (but strongly encourage doing a batch lookup of UUIDs)
Comment on lines
+151
to
+152
| next if agency_uuid.nil? | ||
| [agency_uuid, *row_data] |
Contributor
There was a problem hiding this comment.
this will leave out deleted users, right? should we put like some sort of deleted placeholder?
Contributor
Author
There was a problem hiding this comment.
I believe that for this report we are okay leaving out deleted users.
zachmargolis
approved these changes
Jan 28, 2025
n1zyy
pushed a commit
that referenced
this pull request
Jan 31, 2025
We have an agency partner who requested a specialized report the involves a table with columns representing proofing events and rows representing users for the partner where the values in each cell correspond to whether that user encountered that event in the given time period. We have been manually servicing this request for a little while. This commit adds tooling to generate this report automatically so it does not require manual processing. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an agency partner who requested a specialized report the involves a table with columns representing proofing events and rows representing users for the partner where the values in each cell correspond to whether that user encountered that event in the given time period. We have been manually servicing this request for a little while. This commit adds tooling to generate this report automatically so it does not require manual processing.
This commit does not add the report to the job schedule with the intention being to test it first before scheduling it to run automatically.