Skip to content

Update Pinpoint supported countries #11774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 9 commits into from
Jan 21, 2025
Merged

Update Pinpoint supported countries #11774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16eedaa
Update Pinpoint supported countries
zachmargolis Jan 17, 2025
b2498bf
Update Sender ID support countries
zachmargolis Jan 17, 2025
6f658ff
Specs for Registration Required^9
zachmargolis Jan 17, 2025
8024459
Spacing
zachmargolis Jan 17, 2025
897d862
PR feedback: make ^9 about checking against Sender ID list
zachmargolis Jan 21, 2025
6b6bc93
Add manual overrides back to existing configuration
zachmargolis Jan 21, 2025
06adf9a
Additional overrides
zachmargolis Jan 21, 2025
7ca070b
update after overrides
zachmargolis Jan 21, 2025
45ab989
normalize yaml
zachmargolis Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions config/pinpoint_overrides.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
AE:
supports_sms: false
supports_voice: true
supports_voice_unconfirmed: false
AF:
Expand Down Expand Up @@ -53,6 +54,7 @@ BO:
BR:
supports_voice: false
BY:
supports_sms: true
supports_sms_unconfirmed: false
supports_voice: true
supports_voice_unconfirmed: false
Expand Down Expand Up @@ -126,6 +128,7 @@ IT:
JM:
supports_voice: false
JO:
supports_sms: true
supports_sms_unconfirmed: false
supports_voice: true
supports_voice_unconfirmed: false
Expand All @@ -144,13 +147,16 @@ KI:
supports_sms: true
supports_voice: false
KW:
supports_sms: false
supports_voice: true
supports_voice_unconfirmed: false
KY:
supports_voice: false
KZ:
supports_sms_unconfirmed: false
supports_voice: false
LK:
supports_sms: false
LT:
supports_voice: false
LU:
Expand Down Expand Up @@ -199,6 +205,7 @@ PA:
PE:
supports_voice: false
PH:
supports_sms: true
supports_voice_unconfirmed: false
PK:
supports_sms_unconfirmed: false
Expand All @@ -215,17 +222,20 @@ PW:
supports_sms: true
supports_voice: false
QA:
supports_sms: false
supports_voice: true
supports_voice_unconfirmed: false
RO:
supports_sms_unconfirmed: false
supports_voice: false
RU:
supports_sms: false
supports_voice: true
supports_voice_unconfirmed: false
RW:
supports_sms_unconfirmed: false
SA:
supports_sms: false
supports_voice: true
supports_voice_unconfirmed: false
SI:
Expand All @@ -243,6 +253,7 @@ TD:
supports_sms_unconfirmed: false
supports_voice: false
TH:
supports_sms: true
supports_voice_unconfirmed: false
TJ:
supports_sms_unconfirmed: false
Expand All @@ -253,6 +264,8 @@ TM:
supports_sms_unconfirmed: false
TN:
supports_sms_unconfirmed: false
TR:
supports_sms: false
TT:
supports_voice: false
TW:
Expand All @@ -273,6 +286,7 @@ VC:
VE:
supports_voice: false
VN:
supports_sms: false
supports_voice_unconfirmed: false
YE:
supports_sms_unconfirmed: false
Expand Down
30 changes: 15 additions & 15 deletions config/pinpoint_supported_countries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ AD:
AE:
country_code: '971'
name: United Arab Emirates (UAE)
supports_sms: false
supports_sms: true
supports_voice: false
AF:
country_code: '93'
Expand Down Expand Up @@ -147,7 +147,7 @@ BW:
BY:
country_code: '375'
name: Belarus
supports_sms: true
supports_sms: false
supports_voice: false
BZ:
country_code: '501'
Expand Down Expand Up @@ -272,7 +272,7 @@ EE:
EG:
country_code: '20'
name: Egypt
supports_sms: true
supports_sms: false
supports_voice: false
ER:
country_code: '291'
Expand Down Expand Up @@ -428,7 +428,7 @@ HU:
country_code: '36'
name: Hungary
supports_sms: true
supports_voice: true
supports_voice: false
ID:
country_code: '62'
name: Indonesia
Expand Down Expand Up @@ -482,7 +482,7 @@ JM:
JO:
country_code: '962'
name: Jordan
supports_sms: true
supports_sms: false
supports_voice: false
JP:
country_code: '81'
Expand Down Expand Up @@ -522,7 +522,7 @@ KR:
KW:
country_code: '965'
name: Kuwait
supports_sms: false
supports_sms: true
supports_voice: false
KY:
country_code: '1345'
Expand Down Expand Up @@ -557,7 +557,7 @@ LI:
LK:
country_code: '94'
name: Sri Lanka
supports_sms: false
supports_sms: true
supports_voice: false
LR:
country_code: '231'
Expand Down Expand Up @@ -728,7 +728,7 @@ NL:
country_code: '47'
name: Norway
supports_sms: true
supports_voice: true
supports_voice: false
NP:
country_code: '977'
name: Nepal
Expand Down Expand Up @@ -772,7 +772,7 @@ PG:
PH:
country_code: '63'
name: Philippines
supports_sms: true
supports_sms: false
supports_voice: true
PK:
country_code: '92'
Expand Down Expand Up @@ -807,7 +807,7 @@ PY:
QA:
country_code: '974'
name: Qatar
supports_sms: false
supports_sms: true
supports_voice: false
RE:
country_code: '262'
Expand All @@ -827,7 +827,7 @@ RS:
RU:
country_code: '7'
name: Russia
supports_sms: false
supports_sms: true
supports_voice: false
RW:
country_code: '250'
Expand All @@ -837,7 +837,7 @@ RW:
SA:
country_code: '966'
name: Saudi Arabia
supports_sms: false
supports_sms: true
supports_voice: false
SB:
country_code: '677'
Expand Down Expand Up @@ -932,7 +932,7 @@ TG:
TH:
country_code: '66'
name: Thailand
supports_sms: true
supports_sms: false
supports_voice: true
TJ:
country_code: '992'
Expand Down Expand Up @@ -962,7 +962,7 @@ TO:
TR:
country_code: '90'
name: Turkey
supports_sms: false
supports_sms: true
supports_voice: false
TT:
country_code: '1868'
Expand Down Expand Up @@ -1027,7 +1027,7 @@ VI:
VN:
country_code: '84'
name: Vietnam
supports_sms: false
supports_sms: true
supports_voice: true
VU:
country_code: '678'
Expand Down
2 changes: 2 additions & 0 deletions lib/pinpoint_supported_countries.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ def sms_support
SENDER_ID_COUNTRIES.include?(iso_code) || SENDER_ID_EXCEPTION_COUNTRIES.include?(iso_code)
when 'Registration required3' # basically only India, has special rules
true
when 'Registration required9' # if a sender ID is sent, it must be registered
!SENDER_ID_COUNTRIES.include?(iso_code)
else
true
end
Expand Down
16 changes: 14 additions & 2 deletions spec/lib/pinpoint_supported_countries_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,15 @@
<tr>
<td>India</td>
<td>IN</td>
<td>Registration required<sup><a href="#sms-support-note-3">3</a></sup>
</td>
<td>Registration required<sup><a href="#sms-support-note-3">3</a></sup></td>
<td>Yes</td>
</tr>
<tr>
<td>Zambia</td>
<td>ZM</td>
<td>Registration required<sup><a href="#sms-support-note-9">9</a></sup></td>
<td>No</td>
</tr>
</table>
HTML
end
Expand Down Expand Up @@ -128,6 +133,11 @@
name: India
supports_sms: true
supports_voice: false
ZM:
country_code: '260'
name: Zambia
supports_sms: true
supports_voice: false
STR
end
end
Expand All @@ -141,6 +151,7 @@
PinpointSupportedCountries::CountrySupport.new(iso_code: 'BY', name: 'Belarus', supports_sms: true),
PinpointSupportedCountries::CountrySupport.new(iso_code: 'KY', name: 'Cayman Islands', supports_sms: true),
PinpointSupportedCountries::CountrySupport.new(iso_code: 'IN', name: 'India', supports_sms: true),
PinpointSupportedCountries::CountrySupport.new(iso_code: 'ZM', name: 'Zambia', supports_sms: true),
]
end
# rubocop:enable Layout/LineLength
Expand Down Expand Up @@ -189,6 +200,7 @@
PinpointSupportedCountries::CountryDialingCode.new(country_code: '375', iso_code: 'BY', name: 'Belarus', supports_sms: true, supports_voice: false),
PinpointSupportedCountries::CountryDialingCode.new(country_code: '1345', iso_code: 'KY', name: 'Cayman Islands', supports_sms: true, supports_voice: true),
PinpointSupportedCountries::CountryDialingCode.new(country_code: '91', iso_code: 'IN', name: 'India', supports_sms: true, supports_voice: false),
PinpointSupportedCountries::CountryDialingCode.new(country_code: '260', iso_code: 'ZM', name: 'Zambia', supports_sms: true, supports_voice: false),
]
end
# rubocop:enable Layout/LineLength
Expand Down