LG-15273 Create a Redis Set to track Socure users#11773
Merged
Conversation
Co-authored-by: Abir Shukla <ashukla@gsa.gov>
changelog: Internal, Doc Auth Socure, Create a Redis set to track Socure users
Contributor
|
How long is this meant to be kept around for? |
Contributor
Author
We are keeping it around until we can lift the limit of socure users allowed in. |
Contributor
I think in that case, maybe |
solipet
requested changes
Jan 23, 2025
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Looks great except that I would rename SocureUser to SocureUserSet.
solipet
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15273
🛠 Summary of changes
We created a redis set to track unique socure users and keep a count of them. This gives us the ability to add users and to check the count of socure users.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.