Skip to content

Add in real SORN link#1177

Merged
zachmargolis merged 1 commit intomasterfrom
margolis-real-sorn-link
Mar 6, 2017
Merged

Add in real SORN link#1177
zachmargolis merged 1 commit intomasterfrom
margolis-real-sorn-link

Conversation

@zachmargolis
Copy link
Copy Markdown
Contributor

Why: Our SORN has been officially published

**Why**: Our SORN has been officially published
Copy link
Copy Markdown
Contributor

@el-mapache el-mapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me!

@zachmargolis zachmargolis merged commit e8533ec into master Mar 6, 2017
@hursey013
Copy link
Copy Markdown
Contributor

Beat me to it, I was going to suggest maybe opening this in a new window/tab since it's an external site, but I don't think we have any established rule for that, we seem to do it here and there throughout the app.

@zachmargolis
Copy link
Copy Markdown
Contributor Author

@hursey013 thanks! I'll open a new issue with that question

amoose pushed a commit that referenced this pull request Mar 7, 2017
**Why**: Our SORN has been officially published
amoose pushed a commit that referenced this pull request Mar 8, 2017
**Why**: Our SORN has been officially published
@zachmargolis zachmargolis deleted the margolis-real-sorn-link branch April 6, 2017 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants