allow subdomains of identitysandbox.gov to work#11767
Merged
timothy-spencer merged 11 commits intomainfrom Jan 17, 2025
Merged
Conversation
timothy-spencer
changed the title
…hey allow subdomains of identitysandbox.gov.
timothy-spencer
changed the title
lib/feature_management.rb
Outdated
|
|
||
| def self.prefill_otp_codes_allowed_in_sandbox? | ||
| Identity::Hostdata.domain == 'identitysandbox.gov' && telephony_test_adapter? | ||
| Identity::Hostdata.domain.end_with?('identitysandbox.gov') && telephony_test_adapter? |
Contributor
There was a problem hiding this comment.
Minor risk, but we should probably do something so that abcidentitysandbox.gov doesn't work
Contributor
Author
There was a problem hiding this comment.
I didn't think that this was really going to be a problem, because the real thing that we are looking for is that it's not login.gov, but if you do, I'll put that in. :-)
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This makes it so that we are not required to have LOGIN_DOMAIN set to identitysandbox.gov for certain things to happen, so we can use things like tooling.identitysandbox.gov and have newrelic/prefill_otp_codes_allowed_in_sandbox/current_env_allowed_to_see_gpo_code config work.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.