Conversation
vrajmohan
force-pushed
the
vm-additional-translations
branch
from
212f0d2 to
bfdc22e
Compare
aduth
approved these changes
Jan 23, 2025
app/assets/fonts/glyphs.txt
Outdated
Contributor
There was a problem hiding this comment.
Did you check to see if the font files need to be regenerated? (docs)
It's possible they'd be the same, since I don't know that the original source fonts will have the new characters. (The browser will fall back to a default font, as it does with the other Chinese characters here)
Contributor
Author
There was a problem hiding this comment.
Yes, I executed make link_font_glyphs and was prompted to follow docs/frontend.md#fonts. That resulted in no changes, except app/assets/fonts/glyphs.txt.
changelog: User-Facing Improvements, Translations, Update translations from LQA 1. In French, change NIP to PIN. 2. In Chinese, use full-width parentheses with no extra spaces
vrajmohan
force-pushed
the
vm-additional-translations
branch
from
bfdc22e to
e717cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: User-Facing Improvements, Translations, Update translations from LQA
🎫 Ticket
Link to the relevant ticket:
LG-15508
👀 Screenshots
Screenshots are attached to the ticket