LG-15303: Improve layout of step indicator at high text zoom levels#11758
Merged
LG-15303: Improve layout of step indicator at high text zoom levels#11758
Conversation
When the browser's text zoom level is very high, the step indicator steps can become very crowded. This commit adds a min-width to individual steps that is based on the root font size to prevent this issue. changelog: User-Facing Improvements, Accessibility, Improve step indicator legibility at high text zoom levels
n1zyy
approved these changes
Jan 17, 2025
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
And look at that delightful lack of the word "content" (from "Skip to main content") covering the text at high zoom levels! 😊
Giving this an approval because it's a clean solution that works, but I understand you may experiment further.
Contributor
Author
|
I'm gonna land based on this testing--I've got a 👍 from design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15303
🛠 Summary of changes
When the browser's text zoom level is very high, the step indicator steps can become very crowded.
This commit adds a min-width to individual steps that is based on the root font size to prevent this issue.
👀 Screenshots
Google Chrome (Android)
Safari (iPhone)