Skip to content

LG-14973 Add PII check to Socure flow#11747

Merged
jmax-gsa merged 3 commits intomainfrom
jmax/LG-14973-add-pii-check-to-socure-flow
Jan 22, 2025
Merged

LG-14973 Add PII check to Socure flow#11747
jmax-gsa merged 3 commits intomainfrom
jmax/LG-14973-add-pii-check-to-socure-flow

Conversation

@jmax-gsa
Copy link
Copy Markdown
Contributor

🎫 Ticket

LG-14973

🛠 Summary of changes

Add the PII checks in the DocPiiForm to the Socure flow.

📜 Testing Plan

Verify that the tests in in spec/services/doc_auth/socure/responses/docv_result_response_spec.rb adequately check the functionality and pass.

@jmax-gsa jmax-gsa requested review from a team and amirbey January 14, 2025 15:55
Copy link
Copy Markdown
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we decided to defer displaying PII errors in LG-15307, here when PII fails the below is displayed to the user.
Screenshot 2025-01-15 at 12 27 06 PM

the failing PII scenario can recreated using http://localhost:3000/verify/socure/document_capture_update?docv_token=1111-1111 which passes back an expired date

i think adding a test would be helpful to make sure the user is seeing what we're intending ... thanks!

@jmax-gsa jmax-gsa force-pushed the jmax/LG-14973-add-pii-check-to-socure-flow branch from d9d6b9e to 8568002 Compare January 16, 2025 19:04
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could call this like, local_attribute_validation or something and not have to worry about having pii in the key name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda prefer the clarity, since we have a ticket coming up shortly to actually display more specific errors about pii, and would likely want to use pii* keys anyway; might as well cope with it now.

@jmax-gsa jmax-gsa force-pushed the jmax/LG-14973-add-pii-check-to-socure-flow branch 2 times, most recently from 8c68295 to 422ed47 Compare January 16, 2025 20:40
@jmax-gsa
Copy link
Copy Markdown
Contributor Author

Merging following conversation with @amirbey. Further work from that conversation to be done in LG-15309.

@jmax-gsa jmax-gsa requested a review from amirbey January 17, 2025 17:49
Copy link
Copy Markdown
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@amirbey amirbey self-requested a review January 17, 2025 19:29
Check PII using DocPiiForm.

changelog: Upcoming Features,Socure,Add Idv::DocPiiForm check to Socure flow.
@jmax-gsa jmax-gsa force-pushed the jmax/LG-14973-add-pii-check-to-socure-flow branch from 223ed64 to 61f8dea Compare January 21, 2025 15:33
Copy link
Copy Markdown
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PII validation failure shwos Try Again as expected ... Please respond to @solipet comments on params for the show action on errors controller ... Thanks @jmax-gsa 🙏🏿

@jmax-gsa jmax-gsa merged commit 183e523 into main Jan 22, 2025
@jmax-gsa jmax-gsa deleted the jmax/LG-14973-add-pii-check-to-socure-flow branch January 22, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants