LG-14973 Add PII check to Socure flow#11747
Conversation
There was a problem hiding this comment.
while we decided to defer displaying PII errors in LG-15307, here when PII fails the below is displayed to the user.

the failing PII scenario can recreated using http://localhost:3000/verify/socure/document_capture_update?docv_token=1111-1111 which passes back an expired date
i think adding a test would be helpful to make sure the user is seeing what we're intending ... thanks!
d9d6b9e to
8568002
Compare
There was a problem hiding this comment.
we could call this like, local_attribute_validation or something and not have to worry about having pii in the key name?
There was a problem hiding this comment.
I kinda prefer the clarity, since we have a ticket coming up shortly to actually display more specific errors about pii, and would likely want to use pii* keys anyway; might as well cope with it now.
8c68295 to
422ed47
Compare
|
Merging following conversation with @amirbey. Further work from that conversation to be done in LG-15309. |
Check PII using DocPiiForm. changelog: Upcoming Features,Socure,Add Idv::DocPiiForm check to Socure flow.
223ed64 to
61f8dea
Compare
🎫 Ticket
LG-14973
🛠 Summary of changes
Add the PII checks in the
DocPiiFormto the Socure flow.📜 Testing Plan
Verify that the tests in in
spec/services/doc_auth/socure/responses/docv_result_response_spec.rbadequately check the functionality and pass.