Merged
Conversation
changelog: Internal, Reporting, Create MFA Report script
6f9b521 to
21e71c9
Compare
| ScriptBase::Result.new( | ||
| subtask: 'mfa-report', | ||
| uuids: uuids, | ||
| json: output, |
Contributor
There was a problem hiding this comment.
is this a JSON-only report? might match existing tooling better of we could find a way to do tabular representation?
Contributor
Author
There was a problem hiding this comment.
It is, yeah. I'm not sure what representing as a table could look like since the fields for each MFA type can vary pretty significantly (in content and amount).
Contributor
Author
There was a problem hiding this comment.
More similar to the IG Report than the other reports unfortunately
zachmargolis
approved these changes
Jan 14, 2025
n1zyy
pushed a commit
that referenced
this pull request
Jan 31, 2025
changelog: Internal, Reporting, Create MFA Report script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
https://gitlab.login.gov/lg-teams/agnes/data-warehouse-ag/-/issues/599
🛠 Summary of changes
To make it easier to investigate support cases, this PR creates a new report that can be run by passing a set of UUIDs. It is based on the existing MFA Report used by the IG User Report. I've also added the
platform_authenticatorfield to WebAuthn configurations in the report so we can tell what kind of authenticator it is. I've included a sample of what the report looks like below:Sample Report
[ { "phone_configurations": [ { "id": 1, "phone": "+1 555-000-0000", "created_at": "2025-01-01T00:00:00.000Z", "confirmed_at": "2025-01-01T00:00:00.000Z" } ], "auth_app_configurations": [ { "name": "My auth app", "created_at": "2025-01-01T00:00:00.000Z" } ], "webauthn_configurations": [ { "name": "ABC", "platform_authenticator": false, "created_at": "2025-01-01T00:00:00.000Z" } ], "piv_cac_configurations": [ { "name": "PIV", "created_at": "2025-01-01T00:00:00.000Z" } ], "backup_code_configurations": [ { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null }, { "created_at": "2025-01-01T00:00:00.000Z", "used_at": null } ] } ]