Allow dashboard to set approved status#1174
Merged
Conversation
**Why**: I had mistakenly prevented it due to my misunderstanding of how this works. The dashboard app is correctly only allowing admins to set this attribute, so it's safe for the IdP to allow it through.
amoose
pushed a commit
that referenced
this pull request
Mar 7, 2017
**Why**: I had mistakenly prevented it due to my misunderstanding of how this works. The dashboard app is correctly only allowing admins to set this attribute, so it's safe for the IdP to allow it through.
amoose
pushed a commit
that referenced
this pull request
Mar 8, 2017
**Why**: I had mistakenly prevented it due to my misunderstanding of how this works. The dashboard app is correctly only allowing admins to set this attribute, so it's safe for the IdP to allow it through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: I had mistakenly prevented it due to my misunderstanding of how
this works. The dashboard app is correctly only allowing admins to set
this attribute, so it's safe for the IdP to allow it through.