LG-15453: Fix issue formating heights for AAMVA DLDV#11736
Merged
Conversation
From the AAMVA DLDV guide regarding formatting the height: > Height data should be 3 characters (i.e. 5 foot 7 inches is submitted as 507) We were not previously zero-padding the inches. [skip changelog]
zachmargolis
approved these changes
Jan 10, 2025
n1zyy
approved these changes
Jan 10, 2025
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I have a super-annoying trivial suggestion, which is completely optional. Otherwise A+++ for this bugfix.
Test the "inches >= 10" and "inches < 10" cases
jmhooper
approved these changes
Jan 13, 2025
n1zyy
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15453
🛠 Summary of changes
From the AAMVA DLDV guide regarding formatting the height:
We were not previously zero-padding the inches, leading to us sending "57" in the 5' 7" case.