-
Notifications
You must be signed in to change notification settings - Fork 166
LG-15337: Socure Try again page for hybrid mobile flow
#11734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cd849c3
LG-15337: Try again page for hybrid mobile flow
solipet 383917d
working Try Again feature spec
solipet 686bb59
failing feature spec for opting in to IPP from socure hybrid timeout
solipet 80ef2f9
allows direct to IPP in hybrid flow
solipet 3cb87cc
rename skip_doc_auth_from_socure_hybrid to skip_doc_auth_from_socure
solipet 5500750
fix the IPP `Back` link redirect back to Socure timeout page
solipet 15a6491
Back link from IPP correctly returns to timeout page in both standard…
solipet 6a8224c
remove the default for `in_hybrid_mobile`
solipet 22759ca
fixed spec
solipet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
app/controllers/idv/hybrid_mobile/socure/errors_controller.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module Idv | ||
| module HybridMobile | ||
| module Socure | ||
| class ErrorsController < ApplicationController | ||
| include DocumentCaptureConcern | ||
| include HybridMobileConcern | ||
| include AvailabilityConcern | ||
| include StepIndicatorConcern | ||
| include SocureErrorsConcern | ||
|
|
||
| def show | ||
| error_code = error_code_for(handle_stored_result) | ||
| track_event(error_code: error_code) | ||
| @presenter = socure_errors_presenter(error_code) | ||
| end | ||
|
|
||
| def timeout | ||
| track_event(error_code: :timeout) | ||
| @presenter = socure_errors_presenter(:timeout) | ||
| render :show | ||
| end | ||
|
|
||
| def self.step_info | ||
| Idv::StepInfo.new( | ||
| key: :hybrid_socure_errors, | ||
| controller: self, | ||
| action: :timeout, | ||
| next_steps: [FlowPolicy::FINAL], | ||
| preconditions: ->(idv_session:, user:) do | ||
| true | ||
| end, | ||
| undo_step: ->(idv_session:, user:) {}, | ||
| ) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def rate_limiter | ||
| RateLimiter.new(user: document_capture_session&.user, rate_limit_type: :idv_doc_auth) | ||
| end | ||
|
|
||
| def remaining_submit_attempts | ||
| @remaining_submit_attempts ||= rate_limiter.remaining_count | ||
| end | ||
|
|
||
| def track_event(error_code:) | ||
| attributes = { | ||
| error_code:, | ||
| remaining_submit_attempts:, | ||
| } | ||
|
|
||
| analytics.idv_doc_auth_socure_error_visited(**attributes) | ||
| end | ||
|
|
||
| def socure_errors_presenter(error_code) | ||
| SocureErrorPresenter.new( | ||
| error_code:, | ||
| remaining_attempts: remaining_submit_attempts, | ||
| sp_name: service_provider&.friendly_name || APP_NAME, | ||
| issuer: service_provider&.issuer, | ||
| flow_path: :hybrid, | ||
| ) | ||
| end | ||
|
|
||
| def service_provider | ||
| @service_provider ||= ServiceProvider.find_by(issuer: document_capture_session&.issuer) | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.