Remove outdated package.json version resolutions#11722
Merged
Conversation
mitchellhenke
approved these changes
Jan 8, 2025
zachmargolis
approved these changes
Jan 8, 2025
Contributor
Author
|
The version bump to |
changelog: Internal, Dependencies, Update outdated package version pinning Previously added to pin to versions of subdependencies with fixed security advisories where direct dependencies were using an older version. Direct dependencies now reference fixed versions and the pinned resolutions are no longer necessary. Indirectly resolves an outstanding security advisory in nanoid, using latest version valid by direct dependency using it (postcss). Co-Authored-By: lamcodeofpwnosec <lamcodeofpwnosec@users.noreply.github.com>
aduth
force-pushed
the
aduth-rm-package-resolutions
branch
from
95982d4 to
8868ba3
Compare
kreeksec
approved these changes
Jan 8, 2025
matthinz
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes outdated
resolutionsfields frompackage.json. Indirectly resolves a security advisory withnanoiddependency (CVE-2024-55565).These packages were pinned to specific versions because they were subdependencies with security updates where our direct dependency had not yet updated to the fixed version. Since our direct dependencies are now using updated versions of these packages, the field is no longer necessary.
Previously: #9341
Related: #11719
📜 Testing Plan
Verify there are no audit results after installing Yarn packages:
yarn installyarn audit