Add more accessible headings and titles#1172
Merged
Conversation
**Why**: Make sure pages are using semantic HTML
jessieay
approved these changes
Mar 6, 2017
Contributor
jessieay
left a comment
jessieay
left a comment
There was a problem hiding this comment.
LGTM! I am not 100% clear on why this is more accessible - link?
Contributor
Author
|
@jessieay I linked to the referenced issues above, but basically one page was missing an H1 (Warning: Missing first level heading) and the other had multiple H1s which isn't invalid, but in this particular case wasn't semantic. |
amoose
pushed a commit
that referenced
this pull request
Mar 7, 2017
**Why**: Make sure pages are using semantic HTML
amoose
pushed a commit
that referenced
this pull request
Mar 8, 2017
**Why**: Make sure pages are using semantic HTML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Make sure pages are using semantic HTML for headings.