Task to encrypt existing OTP secret keys#1170
Merged
Conversation
**Why**: Legacy dbs need data migration.
Merged
Contributor
Author
|
IMO we should disable or ignore that codeclimate check. |
Contributor
|
I'm fine with ignoring, but perhaps we can try something to see if it resolves the issue? It doesn't look like we're using batches or index, so maybe we can simplify to |
Contributor
Author
|
The migration code is going to get squashed out of existence per #1168 so let's just ignore. |
amoose
pushed a commit
that referenced
this pull request
Mar 7, 2017
**Why**: Legacy dbs need data migration.
amoose
pushed a commit
that referenced
this pull request
Mar 8, 2017
**Why**: Legacy dbs need data migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Legacy dbs need data migration.