Closed
Conversation
matthinz
requested review from
a team and
jmax-gsa
and removed request for
a team
Add a development-only mock socure doc auth implementation. [skip changelog]
matthinz
force-pushed
the
matthinz/mock-socure-docauth
branch
from
6a63ca6 to
4300dd3
Compare
zachmargolis
reviewed
Jan 3, 2025
|
|
||
| <% if local_assigns.fetch(:show_test_mode_warning, false) %> | ||
| <p> | ||
| <marquee class="bg-accent-warm" ><strong>FOR TESTING ONLY.</strong> This will only <strong>simulate</strong> verifying your documents.</marquee> |
aduth
reviewed
Jan 6, 2025
| private | ||
|
|
||
| def check_not_in_prod | ||
| render_not_found if Rails.env.production? |
Contributor
There was a problem hiding this comment.
All deployed environments (including sandbox environments) are considered production. Is that the behavior we're expecting? I see we're also only registering this route if enable_test_routes is enabled.
I'd wonder if either (a) this isn't needed since we're only registering the route in environments with test routes enabled, or (b) we could rename this to clarify "deployed environments" instead of "production" to try to preempt any potential future misunderstandings.
Contributor
Author
|
Likely won't be back on this for a bit, so closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supports work for
LG-15187
🛠 Summary of changes
Adds a new doc auth vendor,
mock_socurethat allows pretending that the user went through a Socure-like doc auth experience.This mock vendor:
socure_docv_enabledis set totrue📜 Testing Plan
Enable the new vendor:
Then, go through IdV. Socure docv only works on mobile phones, so you need to either:
👀 Screenshots