Skip to content

Aggressively reload A/B tests during spec runs #11693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 1 commit into from
Dec 31, 2024
Merged

Aggressively reload A/B tests during spec runs #11693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions spec/config/initializers/ab_tests_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
require 'rails_helper'

RSpec.describe AbTests do
include AbTestsHelper

after :suite do
reload_ab_tests
end

describe '#all' do
it 'returns all registered A/B tests' do
expect(AbTests.all.values).to all(be_kind_of(AbTest))
Expand Down
5 changes: 5 additions & 0 deletions spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
config.infer_spec_type_from_file_location!

config.include ActiveSupport::Testing::TimeHelpers
config.include AbTestsHelper
config.include EmailSpec::Helpers
config.include EmailSpec::Matchers
config.include AbstractController::Translation
Expand Down Expand Up @@ -165,4 +166,8 @@ class Analytics
],
)
end

config.after(:context) do
reload_ab_tests
end
end