Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/attempts-api-beginning
branch
3 times, most recently
from
9b6bfcd to
7c71cc9
Compare
changelog: Internal, Attempts API, Implement ability to create and store Attempts API events
mitchellhenke
force-pushed
the
mitchellhenke/attempts-api-beginning
branch
from
7c71cc9 to
7de2557
Compare
Sgtpluck
approved these changes
Dec 31, 2024
Contributor
Sgtpluck
left a comment
Sgtpluck
left a comment
There was a problem hiding this comment.
a couple of small questions!
Sgtpluck
approved these changes
Jan 2, 2025
mitchellhenke
pushed a commit
that referenced
this pull request
Jan 8, 2025
This reverts commit 4c4e13f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket: https://gitlab.login.gov/lg-teams/Melba/protocols-backlog/-/issues/138
🛠 Summary of changes
This PR implements the more foundational elements of the Attempts API for event structure and storage in Redis. It is heavily based on the 2022 implementation. It diverges from the previous implementation by being more service provider-agnostic. It's likely the interface to read and write events will change as we continue to develop it, particularly around the handling of the service provider specific parts.