Skip to content

Allow passing PR url to create-release script #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 2 commits into from
Dec 23, 2024
Merged

Allow passing PR url to create-release script #11680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df96e3
Allow pasting PR url in create-release script
matthinz Dec 19, 2024
88dd33f
Use GH_REPO in the pattern passed to sed
matthinz Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/create-release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ DEPLOY_BRANCH=stages/prod
DRY_RUN=${DRY_RUN:-0}
PR_JSON_FILE=${PR_JSON_FILE:-tmp/.pr.json}
CHANGELOG_FILE=${CHANGELOG_FILE:-tmp/.changelog.md}
GH_REPO=${GH_REPO:-18f/identity-idp}
GH_REPO=${GH_REPO:-18F/identity-idp}

USAGE="
${0} [PULL_REQUEST_NUMBER]
${0} [PULL_REQUEST_URL]

Creates a new release based on the given PR having been merged.
"
Expand All @@ -21,6 +21,9 @@ fi

PR="$1"; shift

# Allow just pasting the PR URL
PR=$(echo "$PR" | sed -E "s#https://github.com/${GH_REPO}/pull/([0-9]+).*#\1#i")

if ! which gh > /dev/null 2>&1; then
echo "Github CLI (gh) is not installed. You can install it with: brew install gh"
exit 1
Expand Down