LG-15051: Record correct resolution vendor in proofing components#11674
Merged
LG-15051: Record correct resolution vendor in proofing components#11674
Conversation
1 task
n1zyy
approved these changes
Dec 20, 2024
Contributor
There was a problem hiding this comment.
Unimportant thought: obviously this is actually fine, but using form-handling code makes it look like we're attributing costs based on user input. Not suggesting a change, though.
Save what vendors were used for resolution of the state ID address + residential address. [skip changelog]
- Add a test for undoing verify info - Ensure that the new resolution vendor keys are undid
Include a 50/50 state consideration for now.
matthinz
force-pushed
the
matthinz/15051-save-resolution-vendor
branch
from
7a7df79 to
f2970dd
Compare
matthinz
added a commit
that referenced
this pull request
Jan 8, 2025
In #11674 we added a fallback in the case resolution_vendor was not set in IdV::Session to account for the 50/50 state. Here we remove it, since that's been deployed. [skip changelog]
matthinz
added a commit
that referenced
this pull request
Jan 8, 2025
* Remove fallback to LexisNexis In #11674 we added a fallback in the case resolution_vendor was not set in IdV::Session to account for the 50/50 state. Here we remove it, since that's been deployed. [skip changelog] * Remove another unneeded 50/50 state test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15051
🛠 Summary of changes
Prior to this PR, we always said (in proofing components) that the resolution check was done via LexisNexis.
This PR:
📜 Testing Plan
resolution_checkis set toResolutionMockand thatresidential_resolution_checkis set toResidentialAddressNotRequiredresolution_checkis set toResolutionMockand thatresidential_resolution_checkis also set toResolutionMock