lg-15193 verify socure rate limit display decrements correctly#11671
Merged
AShukla-GSA merged 1 commit intomainfrom Dec 18, 2024
Merged
lg-15193 verify socure rate limit display decrements correctly#11671AShukla-GSA merged 1 commit intomainfrom
AShukla-GSA merged 1 commit intomainfrom
Conversation
… limit count appears correctly
AShukla-GSA
force-pushed
the
lg-15193-socure-attempt-count-bug-fix
branch
from
b274cca to
d5dbf15
Compare
solipet
approved these changes
Dec 18, 2024
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Reviewed with Abir - LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify socure rate limit display decrements correctly
🎫 Ticket
Link to the relevant ticket:
LG-15193
🛠 Summary of changes
Adding feature test to ensure that rate limit value displayed to user on Socure error page is correct and properly decrements as user fails more than once.
Bug was fixed as a part of LG-14010