Add rubocop-capybara to require using path matching helper#11669
Merged
mitchellhenke merged 2 commits intomainfrom Dec 18, 2024
Merged
Add rubocop-capybara to require using path matching helper#11669mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
added 2 commits
December 18, 2024 10:49
changelog: Internal, Testing, Add rubocop-capybara
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We've had some flakier feature tests recently following #11605, and some of them have been alleviated by doing replacements like:
The second line uses the Capybara has_current_path? helper, which includes a timeout to wait for page loads rather than asserting the current_path in that moment in time. This will hopefully make some of the longer or more complicated feature test steps more reliable. There may still be places where we're missing an assertion and should add it before trying to take other actions like clicking on a button.
This PR adds
rubocop-capybaraand enables Capybara/CurrentPathExpectation to require usage of thehave_current_pathhelper.