Skip to content

LG-14998: update language to change #11656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdiarra3 merged 2 commits into from
Dec 18, 2024
Merged

LG-14998: update language to change #11656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c96707
changelog: Upcoming Features, Select email workflow, select email sup…
mdiarra3 Dec 17, 2024
7e3fb5a
Merge remote-tracking branch 'origin/main' into LG-14998-update-langu…
mdiarra3 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/controllers/sign_up/select_email_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ class SelectEmailController < ApplicationController
check_or_render_not_found -> { IdentityConfig.store.feature_select_email_to_share_enabled }
before_action :confirm_two_factor_authenticated
before_action :verify_needs_completions_screen
before_action :verify_multiple_emails

def show
@sp_name = current_sp.friendly_name || sp.agency&.name
Expand Down Expand Up @@ -56,10 +55,6 @@ def last_email
end
end

def verify_multiple_emails
redirect_to sign_up_completed_path if user_emails.count < 2
end

def verify_needs_completions_screen
redirect_to account_url unless needs_completion_screen_reason
end
Expand Down
10 changes: 0 additions & 10 deletions spec/controllers/sign_up/select_email_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,6 @@
end
end

context 'with only one verified email address' do
let(:user) { create(:user) }

it 'redirects to the sign up completed path' do
response

expect(response).to redirect_to(sign_up_completed_path)
end
end

context 'when users has max number of emails' do
before do
allow(user).to receive(:email_address_count).and_return(2)
Expand Down