LG-15223 Delete deprecated FSM State ID URL

[gina-yamada]

🎫 Ticket

LG-15223 Take Two - FSM/State ID - Delete url:9

🛠 Summary of changes

• Delete deprecated FSM routes (GET, PUT) /in_person_proofing/state_id

📜 Testing Plan

Check Route in Production Logs

• Step 1 Sign in to CloudWatch Production. Check production logs to ensure route verify/in_person_proofing/state_id has not been visited recently. PR#11545 redirected the deprecated routes to the new url. It was deployed in production 11/26/24 so there should be no visits to the deprecated route after this date. CloudWatch query here - just modify dates (suggested 11/25 - now)

Test Application

• Step 1 Start the app locally and come in through Sinatra. Create an account. Start to step through the ID-IPP flow. Stop when you are on the State ID page.
• Step 2 Check the url- ensure it is /verify/in_person/state_id.
• Step 3 Fill out the state id form but cause an error, ie: add a comma in the City input field. Click on the Continue button. Check the server- confirm all state_id routes (GET and PUT) are /verify/in_person/state_id and that you do not see /verify/in_person_person/state_id (This is where/how we saw the old route getting hit when we previously thought we depreciated it but it we still being found in CloudWatch logs.)
• Step 4 Once on 'Verify your information' (/verify/in_person/verify_info), click Update to edit the State Id page. Confirm again you are on url /verify/in_person/state_id and the terminal GET has /verify/in_person/state_id as the route (and not the deprecated route). You can create an another error to check PUT again but not necessary.
• Step 5 Continue through the flow to create an enrollment.
• Step 6 Run through ID-IPP - click back links (and different ways to hit State ID page) all while checking that the deprecated route is not hit.

[aduth]

Checked CloudWatch, not seeing any activity 🙌

[jennyverdeyen]

Tested manually according to your steps and the old routes are nowhere to be found! Yay!

[shanechesnutt-ft]

@gina-yamada can you rebase this branch it is 25 commits behind main. I would like to test it with the latest code.

[gina-yamada]

@shanechesnutt-ft I just rebased

[shanechesnutt-ft]

I ran through the test plan. Everything looked good! 👍🏻

[gina-yamada]

I checked CW again this morning, no activity - merging.