Conversation
spec/models/service_provider_spec.rb
Outdated
There was a problem hiding this comment.
why do we have a live? method rather than just using active? ?
There was a problem hiding this comment.
I believe it's because we want to have the ability to approve SPs once we go live rather than automatically allow any SP that gets published on the dashboard. Currently, live? is not being used, but we want to be able to use it in the future. https://github.com/18F/identity-idp/blob/master/app/services/saml_request_validator.rb#L31
**Why**: To have complete code coverage.
monfresh
force-pushed
the
mb-service-provider-specs
branch
from
75b2afd to
4d61d72
Compare
| class ServiceProviderUpdater | ||
| PROTECTED_ATTRIBUTES = [ | ||
| :id, | ||
| :approved, |
There was a problem hiding this comment.
@monfresh what was the reason for making approved a protected attribute here? I think this may have resulted in a bug where we can't create new approved SPs from the dashboard app
There was a problem hiding this comment.
@zachmargolis is correct -- the approved flag should be a pass-through from the dashboard.
There was a problem hiding this comment.
Gotcha. I'm assuming the approved flag can only be set by admins on the dashboard, and that we prevent people from manually changing the form such that it submits the approved attribute?
There was a problem hiding this comment.
**Why**: To have complete code coverage.
**Why**: To have complete code coverage.
4 participants
Why: To have complete code coverage.