Fix Face/Touch recommendation duplicate submission#11608
Merged
Conversation
changelog: Bug Fixes, Face/Touch Recommendation, Fix edge case for duplicate submission in recommendation
mitchellhenke
approved these changes
Dec 6, 2024
kevinsmaster5
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an edge-case where an error may occur during redirect of skipped Face/Touch Unlock recommendation if user submits multiple times.
Fixes include:
SubmitButtonComponentwhich has built-in duplicate submission preventionnilredirect would otherwise be usedMore explanation in related Slack thread: https://gsa-tts.slack.com/archives/C01710KMYUB/p1733496464529579
📜 Testing Plan
Verify no 500 errors in following test flow:
Reconfigure to force recommendation A/B test to always be visible: