LG-10206 Move STEP_INDICATOR_STEP constants out of InPersonFlow

[jennyverdeyen]

🎫 Ticket

Link to the relevant ticket:
LG-10206

🛠 Summary of changes

Moves STEP_INDICATOR_STEPS from InPersonFlow into StepIndicatorConcern. InPersonFlow is FSM-related and will get deleted in a future clean-up PR, so these constants need to be moved as they are still used for the IPP step indicator. References to the old Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS are updated to reference the new constants.

Note: For 50/50 state management, the old constants in the InPersonFlow are not being removed in this PR.

📜 Testing Plan

No new features or behavior was added - regression testing would be good:

• Perform manual regression testing of the IPP flow, as well as hybrid and remote flows to be thorough.
• Ensure tests pass

[jennyverdeyen]

This was probably just missed in the IPP GPO removal, I did some manual testing and this condition should never be true. There is no longer a need for IPP GPO steps so I updated this block.

[eileen-nava]

I tested manually. On the state id page, I killed the server while it was running on main, switched to main, and was able to successfully move forward in the app. Caveat: I didn't manually test the hybrid flow. Also, I tested ipp, but not gpo.

[eileen-nava]

👏🏻 Thanks for investigating this after our slack conversation.

[gina-yamada]

I think we talked about this before the hackathon- you will delete STEP_INDICATOR_STEPS in InPersonFlow (and probably STEP_INDICATOR_STEPS_GPO) in a follow up PR because of 50/50 state.

This looks good to me. I don't see other instances of Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS being used in the code. I walked through IPP, GPO, Remote, and hybrid. Steps in step indicator are what I'd expect and I move through flow as I'd expect.

Nice work Jenny 🚀