LG-15177 Add a CTA to return to an SP after entering a verify-by-mail code#11602
Merged
LG-15177 Add a CTA to return to an SP after entering a verify-by-mail code#11602
Conversation
Contributor
Author
|
Here are the screenshots:
|
aduth
reviewed
Dec 5, 2024
aduth
reviewed
Dec 5, 2024
app/services/analytics_events.rb
Outdated
Comment on lines
812
to
838
Contributor
There was a problem hiding this comment.
Where are these being passed?
Contributor
Author
There was a problem hiding this comment.
These need to be documented since they are added by AnalyticsEventsEnhancer. Otherwise the feature tests get cranky about undocumented params.
… code In #11591 we added a `post_idv_follow_up_url` that allows users to return to a service provider after finishing verification out-of-band. This commit puts this new URL to work in the verify-by-mail code. After this commit user's who enter a verify-by-mail code without an SP in their session will see a new SP follow-up screen. This screen includes a CTA that prompts the user to connect their account to the service provider they started proofing with. This link leads to the new post-IdV follow-up URL. changelog: User-Facing Improvements, Verify-by-mail, A CTA was added to prompt users to return to the service provider after verify-by-mail
jmhooper
force-pushed
the
jmhooper-add-enter-code-interstitial
branch
from
5618bb1 to
0b1196f
Compare
jmhooper
force-pushed
the
jmhooper-add-enter-code-interstitial
branch
from
37fc51d to
f8f4d48
Compare
n1zyy
approved these changes
Dec 6, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
This all looks good to me!
I have a little bit of a feeling that people might think "Go to account" in this context refers to their SP account; e.g., do I want to connect to my SSA account, or do I want to go right to my SSA account? But my "little bit of a feeling" should definitely not block anything now.
Co-authored-by: Matt Wagner <matt.wagner@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11591 we added a
post_idv_follow_up_urlthat allows users to return to a service provider after finishing verification out-of-band.This commit puts this new URL to work in the verify-by-mail code. After this commit users who enter a verify-by-mail code without an SP in their session will see a new SP follow-up screen. This screen includes a CTA that prompts the user to connect their account to the service provider they started proofing with. This link leads to the new post-IdV follow-up URL.