LG-15197: Omit policy_details_api from ThreatMetrix response body logging#11601
Merged
LG-15197: Omit policy_details_api from ThreatMetrix response body logging#11601
Conversation
…ging changelog: Internal, Anti-Fraud, Omit policy_details_api from ThreatMetrix response body logging
matthinz
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15197
🛠 Summary of changes
Updates ThreatMetrix
ResponseRedactorto removepolicy_details_apifrom the list of allowed fields, to prevent it from being logged.The
policy_details_apifield value is very large, and its properties are available through another of the logged fields (tmx_variables). The net effect of removingpolicy_details_apiis a 73% reduction in the log size for theresponse_bodyfield.📜 Testing Plan
While there's no test coverage spanning individual keys, the allowlist behavior can be verified with existing specs for the redactor class: