Improve flash message when page is refreshed#1160
Conversation
There was a problem hiding this comment.
I duplicated this method a bit in openid_connect/authorization_controller.rb -- can you rebase and add this there too? 😀 I can try to refactor it after too so we can share more code
There was a problem hiding this comment.
the description for this is a lie, it looks like issuer is added to the url and not sp_name
There was a problem hiding this comment.
I would escape the param here for consistency: issuer=http%3A%2F%2Flocalhost%3A3000
**Why**: To give users more context on why we refresh the page and clear the form inputs.
**Why**: Pass tests
hursey013
force-pushed
the
bh-timeout-messages
branch
2 times, most recently
from
e7be003 to
f96af43
Compare
|
@zachmargolis updated! |
There was a problem hiding this comment.
I personally don't think there's ever a good reason to disable AbcSize. It's a sign the method is too complex. A method can always be refactored to eliminate the offense. I'd be happy to take a look to see how we can improve this code.
There was a problem hiding this comment.
Yeah we have the max size for a method set to 15 in rubocop and this particular method was at 15.07... couldn't think of a way to restructure it any further but definitely open to suggestions.
There was a problem hiding this comment.
I'm fine with this for now. I'll refactor after this gets merged. There are a lot of things that need to be cleaned up now that we are storing Service Providers in the database.
**Why**: Making it better
hursey013
force-pushed
the
bh-timeout-messages
branch
from
f96af43 to
d4564e9
Compare
* Improve flash message when page is refreshed **Why**: To give users more context on why we refresh the page and clear the form inputs.
* Improve flash message when page is refreshed **Why**: To give users more context on why we refresh the page and clear the form inputs.
3 participants
To give users more context on why we refresh the page and clear the form inputs.
When accessing app directly:
When accessing from service provider:
