Skip to content

Lg-14279 document request analytics event#11581

Merged
AShukla-GSA merged 11 commits intomainfrom
lg-14279-document-request-analytics-event
Dec 9, 2024
Merged

Lg-14279 document request analytics event#11581
AShukla-GSA merged 11 commits intomainfrom
lg-14279-document-request-analytics-event

Conversation

@AShukla-GSA
Copy link
Copy Markdown
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-14279

🛠 Summary of changes

Adding Logging for Socure document request

Copy link
Copy Markdown
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are intending to log the DocumentRequest. This appears to be logging the verificationData request

@AShukla-GSA AShukla-GSA force-pushed the lg-14279-document-request-analytics-event branch from 2104faf to 09a152d Compare December 3, 2024 20:30
@AShukla-GSA AShukla-GSA requested a review from amirbey December 4, 2024 16:34
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in an existing standard and hybrid flow spec can we add a expect check using fake_analytics for the happy path, network error, and invalid request? 🙏🏿 the invalid request might be the only spec that doesn't exist

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we still add a check to the network error spec?
can we create a spec for an invalid request ... for example, if we pass the wrong api secret key?

can we add fake analytics checks to the hybrid flow specs?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the analytics check to the hybrid spec. Can you add also add the checks in the hybrid spec for the same scenarios as you did for the standard flow (ie: network error, invalid response(401), ...) ?

@AShukla-GSA AShukla-GSA requested a review from amirbey December 4, 2024 22:32
@AShukla-GSA AShukla-GSA force-pushed the lg-14279-document-request-analytics-event branch from 2e4099d to 9085ab5 Compare December 5, 2024 18:58
@AShukla-GSA AShukla-GSA requested a review from amirbey December 5, 2024 21:28
@AShukla-GSA AShukla-GSA force-pushed the lg-14279-document-request-analytics-event branch from 6c76c33 to 60374be Compare December 7, 2024 20:40
@AShukla-GSA AShukla-GSA requested a review from amirbey December 7, 2024 20:52
@AShukla-GSA AShukla-GSA force-pushed the lg-14279-document-request-analytics-event branch from 60374be to 2791228 Compare December 9, 2024 15:50
@AShukla-GSA AShukla-GSA merged commit e44b47f into main Dec 9, 2024
@AShukla-GSA AShukla-GSA deleted the lg-14279-document-request-analytics-event branch December 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants