Lg-14279 document request analytics event#11581
Conversation
amirbey
left a comment
There was a problem hiding this comment.
We are intending to log the DocumentRequest. This appears to be logging the verificationData request
2104faf to
09a152d
Compare
app/controllers/idv/hybrid_mobile/socure/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/idv/hybrid_mobile/socure/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/idv/hybrid_mobile/socure/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
in an existing standard and hybrid flow spec can we add a expect check using fake_analytics for the happy path, network error, and invalid request? 🙏🏿 the invalid request might be the only spec that doesn't exist
There was a problem hiding this comment.
can we still add a check to the network error spec?
can we create a spec for an invalid request ... for example, if we pass the wrong api secret key?
can we add fake analytics checks to the hybrid flow specs?
There was a problem hiding this comment.
thanks for adding the analytics check to the hybrid spec. Can you add also add the checks in the hybrid spec for the same scenarios as you did for the standard flow (ie: network error, invalid response(401), ...) ?
2e4099d to
9085ab5
Compare
6c76c33 to
60374be
Compare
60374be to
2791228
Compare
🎫 Ticket
Link to the relevant ticket:
LG-14279
🛠 Summary of changes
Adding Logging for Socure document request