Skip to content

Update report to use earlier event #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sgtpluck merged 2 commits into from
Dec 9, 2024
Merged

Update report to use earlier event #11570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197c284
Update report to use earlier event
Sgtpluck Nov 27, 2024
8db9345
changelog: Internal, Analytics, Update signature query to use more ac…
Sgtpluck Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/reporting/protocols_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class ProtocolsReport
attr_reader :time_range

SAML_AUTH_EVENT = 'SAML Auth'
SAML_AUTH_REQUEST_EVENT = 'SAML Auth Request'
OIDC_AUTH_EVENT = 'OpenID Connect: authorization request'

# @param [Range<Time>] time_range
Expand Down Expand Up @@ -352,7 +353,7 @@ def protocol_query

def saml_signature_query
params = {
events: quote([SAML_AUTH_EVENT]),
events: quote([SAML_AUTH_REQUEST_EVENT]),
}

format(<<~QUERY, params)
Expand All @@ -362,7 +363,6 @@ def saml_signature_query
properties.event_properties.request_signed != 1 AS not_signed,
isempty(properties.event_properties.matching_cert_serial) AND signed AS invalid_signature
| filter name IN %{events}
AND properties.event_properties.success = 1
| stats
sum(not_signed) AS unsigned_count,
sum(invalid_signature) AS invalid_signature_count
Expand Down