LG-13006: remove skip_doc_auth from session#11569
Merged
Conversation
KeithNava
force-pushed
the
keithw/LG-13006-complete-removal-of-skip-doc-auth
branch
from
a5fb895 to
46faedb
Compare
shanechesnutt-ft
approved these changes
Nov 27, 2024
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Double checked that no skip_doc_auth references exist. Looks good to me! 👍🏻
eileen-nava
approved these changes
Dec 2, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
I did a manual test and was able to verify via ID-IPP. I double-checked there are no remaining instances of skip_doc_auth. Good work. 👏🏻
KeithNava
deleted the
keithw/LG-13006-complete-removal-of-skip-doc-auth
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13006
🛠 Summary of changes
Removing the last use of the unused
skip_doc_authfrom the session📜 Testing Plan
Since the use business logic using the older
skip_doc_authvariable was already removed the automated tests should be enough.