Merged
Conversation
Contributor
Author
|
I'm marking this a WIP since it looks like |
Contributor
Or switch back to |
Contributor
Author
|
I ended up coming up with this: def pii_from_doc
return nil if session[:pii_from_doc].blank?
state_id_data = Pii::StateId.members.index_with { |key| session[:pii_from_doc][key] }
Pii::StateId.new(**state_id_data)
endThis should build out a hash with all of the required args even if they aren't present in the session. The old implementation should be compatible since it will remove the unsupported args with |
f8f3281 to
e954f2c
Compare
We are planning to validate additional data that appears on the state ID with the issuing source via DLDV. In order to facilitate this new feature this change adds fields for the new attributes to the `StateId` struct. This struct is used to represent the State ID data when it is in the IdV session. [skip changelog]
e954f2c to
1f7013a
Compare
n1zyy
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are planning to validate additional data that appears on the state ID with the issuing source via DLDV. In order to facilitate this new feature this change adds fields for the new attributes to the
StateIdstruct. This struct is used to represent the State ID data when it is in the IdV session.