Skip to content

LG-15054: Remove GPO from IPP step indicator #11519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eileen-nava merged 2 commits into from
Nov 18, 2024
Merged

LG-15054: Remove GPO from IPP step indicator #11519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b800081
remove steps for user who is in both GPO + IPP flow: this scenario is…
eileen-nava Nov 15, 2024
535a8c7
Changelog: Internal, In-person proofing, remove IPP+GPO scenario from…
eileen-nava Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions app/controllers/concerns/idv/step_indicator_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,7 @@ module StepIndicatorConcern

def step_indicator_steps
if in_person_proofing?
if gpo_address_verification?
Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS_GPO
else
Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS
end
Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS
elsif gpo_address_verification?
Idv::StepIndicatorConcern::STEP_INDICATOR_STEPS_GPO
else
Expand Down
24 changes: 0 additions & 24 deletions spec/controllers/concerns/idv/step_indicator_concern_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,6 @@ def force_gpo
]
end

context 'via pending profile' do
let(:profile) do
create(
:profile,
gpo_verification_pending_at: 1.day.ago,
proofing_components: { 'document_check' => Idp::Constants::Vendors::USPS },
)
end

it 'returns in person gpo steps' do
ProofingComponent.create(user: user, document_check: Idp::Constants::Vendors::USPS)
create(:in_person_enrollment, :establishing, user: user)
expect(steps).to eq in_person_step_indicator_steps_gpo
end
end

context 'via current idv session' do
before do
ProofingComponent.create(user: user, document_check: Idp::Constants::Vendors::USPS)
Expand All @@ -110,14 +94,6 @@ def force_gpo
it 'returns in person steps' do
expect(steps).to eq in_person_step_indicator_steps
end

context 'with gpo address verification method' do
before { force_gpo }

it 'returns in person gpo steps' do
expect(steps).to eq in_person_step_indicator_steps_gpo
end
end
end

context 'when user is not signed in' do
Expand Down